Skip to content

Update UserResource.php#7

Open
lcqcool wants to merge 1 commit into
zenobio93:3.0.xfrom
lcqcool:patch-1
Open

Update UserResource.php#7
lcqcool wants to merge 1 commit into
zenobio93:3.0.xfrom
lcqcool:patch-1

Conversation

@lcqcool

@lcqcool lcqcool commented Nov 20, 2025

Copy link
Copy Markdown

Fix the incorrect structure for API response
Before this fix, it returns null

    {
      "user_id": null,
      "connector_type": null,
      "connector_id": null,
      "connector_name": null
    },

Fix the incorrect structure for API response

@AkovStohs AkovStohs left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is on lines 67-70, this creates shadow properties on the class that shouldnt be there, while your fix correctly updates the shadow properties, It might be better to remove the shadow properties instead

I also submitted a PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants